ENH: clarify error message when multiplying bool times Timedelta #63139
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
added
Timedelta
Member
|
This is t already disallowed? |
Contributor
Author
@jbrockmendel, thank you for taking a look at this PR. Yes, it's correct, it is disallowed. I thought we wanted to improve the error message. Did I get your comment #62316 (comment) wrong? Maybe I should rename my PR to "ENH: clarify error message …" Update: renamed it |
natmokval
changed the title
pandas/_libs/tslibs/timedeltas.pyx
Outdated
| # GH#62316 | ||
| raise TypeError( | ||
| "Cannot multiply Timedelta by bools. " | ||
| "Explicitly cast to integers instead." |
Contributor
Author
There was a problem hiding this comment.
thanks, I've changed it to singular
Member
|
can you add a test |
Member
|
BTW there are a few issues with the "Numeric Operations" label and "MultiIndex" label about silent alignment on arithmetic between Series/Frame with non-aligned MultiIndexes. While looking at them the other day I thought that might be a good topic for you to tackle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.